feat(idl): indirect csr support #594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us test idl for any config from the command line: ./do test:idl qc_iu
This does three things:
* Remove `CSR[expression]` syntax for direct CSR reads
** `CSR[csr_name]` still works
* Adds `direct_csr_lookup`/`csr_{hw,sw}_{read,write}` functions to access a
CSR with a direct address
* Adds `indirect_csr_lookup` to access an indirect CSR with an indirect address
This adds a boolean writeable field to the CSR schema. We need this for two reasons: * Indirect CSRs that have no address convention * CSRs like mscontext that don't follow the direct address convention
dhower-qc
added
schema
This was referenced Apr 4, 2025
This lets us test idl for any config from the command line: ./do test:idl qc_iu
This does three things:
* Remove `CSR[expression]` syntax for direct CSR reads
** `CSR[csr_name]` still works
* Adds `direct_csr_lookup`/`csr_{hw,sw}_{read,write}` functions to access a
CSR with a direct address
* Adds `indirect_csr_lookup` to access an indirect CSR with an indirect address
This adds a boolean writeable field to the CSR schema. We need this for two reasons: * Indirect CSRs that have no address convention * CSRs like mscontext that don't follow the direct address convention
ThinkOpenly
reviewed
Apr 8, 2025
ThinkOpenly
reviewed
Apr 8, 2025
ThinkOpenly
reviewed
Apr 8, 2025
Collaborator
ThinkOpenly
left a comment
ThinkOpenly
left a comment
There was a problem hiding this comment.
Spell-o in that first comment "enviornment".
Also, if you're going to edit that commit message, please modify the example to:
For example:
./do test:idl qc_ui
Collaborator
Author
This PR is a good squash candidate. I've updated the PR description, which I think gets used as the squash commit message. |
Collaborator
Author
done |
Collaborator
Author
|
@ThinkOpenly, this one should be ready modulo any requests from you. |
ThinkOpenly
approved these changes
Apr 30, 2025
Signed-off-by: Derek Hower <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSR[expression]syntax for CSR direct address lookuptest:idl.For example:
closes #589